Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logic for excluding "ShowInSearch" on models #4

Open
robbieaverill opened this issue Apr 3, 2018 · 1 comment
Open

Improve logic for excluding "ShowInSearch" on models #4

robbieaverill opened this issue Apr 3, 2018 · 1 comment
Labels
affects/v4 complexity/low impact/low type/enhancement New feature or request

Comments

@robbieaverill
Copy link
Contributor

See comment: https://github.com/silverstripe/cwp/pull/64/files#r178983597

We could probably do this as a dynamic lookup for the ShowInSearch field existing and being falsy, then exclude classes that have that dynamically rather than specifically mentioning SiteTree and File.

I think I might have removed the File equivalent during upgrading from CWP 1.x to 2.x
@jakxnz jakxnz mentioned this issue Apr 3, 2018
Closed
@chillu
Copy link
Member

chillu commented May 31, 2019

I think I might've created a duplicate at #23, but with more depth and more rationale why this is a higher impact than "low".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/low impact/low type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chillu @emteknetnz @robbieaverill