Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple from cwp/cwp #7

Open
chillu opened this issue Apr 30, 2018 · 1 comment
Open

Decouple from cwp/cwp #7

chillu opened this issue Apr 30, 2018 · 1 comment
Labels
affects/v4 complexity/low impact/medium type/enhancement New feature or request

Comments

@chillu
Copy link
Member

chillu commented Apr 30, 2018

The cwp/cwp modules comes with all kinds of semi-useful baggage like EventsPage, which most installations don't need - even in CWP 2.0. We should split out those features into their own module, similar to this cwp/cwp-search module. But until then, what's the reason this module depends on cwp/cwp? It applies some extension to BasePageController which seems to be applicable to PageController as well. And the page types extend Page, not BasePage. Is there any coupling here?
@robbieaverill
Copy link
Contributor

The main reason it's coupled to CWP is because we removed it from CWP originally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/low impact/medium type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chillu @emteknetnz @robbieaverill