Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banner file uploads should be restricted to images only #72

Open
unclecheese opened this issue Jun 25, 2019 · 6 comments
Open

Banner file uploads should be restricted to images only #72

unclecheese opened this issue Jun 25, 2019 · 6 comments
Labels
affects/v4 complexity/low impact/medium type/bug

Comments

@unclecheese
Copy link

Screenshot 2019-06-25 13 07 35
@unclecheese
Copy link
Author

The title of the issue is incorrect. It's not overlapping file blocks. Those file names are part of the banner block, but either way, it looks out of place.

@unclecheese unclecheese changed the title Banner block overlaps file blocks Banner file attachments not displaying properly Jun 25, 2019
@robbieaverill
Copy link
Contributor

Are you using a PDF in the banner block?

@unclecheese
Copy link
Author

Yes. Is that the intended use?

@robbieaverill
Copy link
Contributor

No, it's intended that you'd use an image in the banner block, it's displayed as the background of the banner. Either way, there's something we can fix here

@unclecheese
Copy link
Author

Would it make sense to change this issue to "Banner files should be images only"?

@robbieaverill
Copy link
Contributor

Yeah I think so

@robbieaverill robbieaverill changed the title Banner file attachments not displaying properly Banner file uploads should be restricted to images only Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/low impact/medium type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@unclecheese @emteknetnz @robbieaverill