Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codecov code should be fixed or disabled #26

Open
emteknetnz opened this issue Jul 17, 2022 · 1 comment
Open

codecov code should be fixed or disabled #26

emteknetnz opened this issue Jul 17, 2022 · 1 comment
Labels

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Jul 17, 2022

Codecov is being disabled from automatically running on the silverstripe account because it's causing segfaults

e.g.
https://github.com/silverstripe/silverstripe-blog/runs/7349442321?check_suite_focus=true
/home/runner/work/_temp/b2c83dc1-1b66-44c5-af39-62cd737a1bbb.sh: line 9: 5368 Segmentation fault (core dumped) phpdbg -qrr vendor/bin/phpunit --coverage-clover=coverage.xml

Either
a) investigate a fix the issue, likely would need to change from what use use for creating the coverage report
b) give up on the idea of code coverage entirely and remove the code from gha-ci, as well as the phpcoverage_force_off option from gha-generate-matrix and any modules that use the option

@GuySartorelli
Copy link
Member

Note also that with force codecov enabled, modules which have no tests still get a codecov job created (e.g. https://github.com/silverstripe/silverstripe-testsession/runs/7380667649?check_suite_focus=true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants