Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root .htaccess doesn't get installed when using the public webroot #50

Open
maxime-rainville opened this issue Sep 24, 2019 · 1 comment

Comments

@maxime-rainville
Copy link
Contributor

There's an access .htaccess file that is meant to be copied to your project root when you are using the public web folder. However, it does not. The file exists, but there's no project-files extra directive for it in recipe-core's composer.json file.

This is probably because we're afraid it might conflict with the public-files one when you're not using the public web root.

This means that a project set up only with recipe-core (without silverstripe/installer) will not work out of the box with SSP if using the public web root.

Steps to reproduce

  • Create an empty folder
  • Add an empty public folder
  • Initialise a composer file
  • Require silverstripe/recipe-core

Expected result: recipe-core's root .htaccess has been copied to root of my empty project and my project is deployable to SSP.
Actual result: There's no .htaccess file in my project root and if I try to deploy it to SSP, I'll get a 403 Forbidden error.

@maxime-rainville
Copy link
Contributor Author

The fix for this might involved updating recipe-plugin to always start by copying "public-files" and only copy the "project-files" if they don't conflict with the public files we just copied over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant