Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate GraphQL4 file sort behaviour #1283

Closed
emteknetnz opened this issue Jul 25, 2022 · 1 comment
Closed

Investigate GraphQL4 file sort behaviour #1283

emteknetnz opened this issue Jul 25, 2022 · 1 comment
Labels
affects/v4 complexity/medium impact/low type/bug

Comments

@emteknetnz
Copy link
Member

This PR uncovered that folders no longer sorted alpha like they did in graphql3. Instead #1282

That PR just handled the most common scenario where File::$default_sort is unmodified from \""Name\"". Possibly graphql3 was able to handle \"File\".\"Name\" style syntax or ""Name" DESC" or ["File" => 'DESC] syntax, if so, graphql4 should be able to do the same
@emteknetnz
Copy link
Member Author

emteknetnz commented Jul 26, 2022 •
edited
Loading

Implemented default_sort in linked PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/medium impact/low type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emteknetnz