Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Categories and Tags configurable #537

Closed
chromos33 opened this issue Jun 13, 2018 · 4 comments
Closed

Make Categories and Tags configurable #537

chromos33 opened this issue Jun 13, 2018 · 4 comments

Comments

@chromos33
Copy link

Would be nice if it were possible (out of the box) if the used TagFields/GridFields that are used for Categories and Tags were configurable.
For example that you could config the Field that (Blog.php::162) uses to sort BlogTags (and BlogCategores) by another Field instead of static "Title"

I.e. for Compatibility with tractorcow/silverstripe-fluent.

@robbieaverill
Copy link
Contributor

You could add an extension to modify the fields, since they're created in a beforeUpdateCMSFields callback they'll always be adjustable by extensions. Are you experiencing a particular problem with fluent in conjunction with this?

I'll triage this as an enhancement for now.

@chromos33
Copy link
Author

chromos33 commented Jun 14, 2018

Already did this myself just wanted do open a Ticket to make a suggestion.

The problem is with how fluent rewrites Queries making Sorting currently breaking everything with it because of MYSQL error something along the lines of using DISTINCT and Sort when the Sort parameter no longer being in the Select. If Title is to be translated which in most cases it is.

Already opened a Ticket on their side as well

@robbieaverill
Copy link
Contributor

robbieaverill commented Jun 14, 2018

Oh OK. Related PR to add sorting capability to fluent: tractorcow-farm/silverstripe-fluent#415

@robbieaverill
Copy link
Contributor

I think this is fixed in fluent. Blog fields are extensible so you can adjust them if required. I'm not sure there's anything left over, but feel free to reopen if I've misunderstood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants