Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra icons in add category and tag button #735

Closed
satrun77 opened this issue Dec 18, 2023 · 4 comments
Closed

Extra icons in add category and tag button #735

satrun77 opened this issue Dec 18, 2023 · 4 comments

Comments

@satrun77
Copy link
Contributor

satrun77 commented Dec 18, 2023

In the latest version add category and tag buttons with invalid layout.

Screenshot 2023-12-19 at 12 19 54 PM

What should this be? no icon or with a specific icon? I think the icon should not be added.

No icon to remove this line https://github.com/silverstripe/silverstripe-blog/blob/4/src/Forms/GridField/GridFieldAddByDBField.php#L229

I could do PR if you advise on what its expected

PRs

@sabina-talipova
Copy link
Contributor

@satrun77, thank you that open this ticket.
This is a regression defect. This button should not have any icons. We will be really grateful if you help solve this issue.

@sabina-talipova
Copy link
Contributor

The problem is related to this issue.
silverstripe/silverstripe-cms#2885

@satrun77
Copy link
Contributor Author

PR to remove the icon attribute #736

@GuySartorelli
Copy link
Member

PR merged. It'll be automatically tagged by GitHub actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants