Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Deprecate widget classes #779

Merged
merged 1 commit into from
Aug 20, 2024
Merged

API Deprecate widget classes #779

merged 1 commit into from
Aug 20, 2024

Conversation

emteknetnz
Copy link
Member

Issue #589

@emteknetnz emteknetnz mentioned this pull request Aug 20, 2024
Closed
1 task
@emteknetnz emteknetnz force-pushed the pulls/4/deprecate-widgets branch from a55493f to 7ad58bb Compare August 20, 2024 01:29
GuySartorelli
GuySartorelli requested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's templates to delete too, e.g. templates/WidgetHolder.ss
There's also scss, docs, test files (e.g. tests/behat/src/FeatureContext.php), and config related to widgets that all need to be removed - and a mention in the readme.

@emteknetnz
Copy link
Member Author

Have created 5.3.0 changelog PR - silverstripe/developer-docs#567

Re templates etc - this is just the deprecation PR, not the removal PR, that happens in CMS 6

@GuySartorelli
Copy link
Member

Oh yup sorry, got ahead of myself.

GuySartorelli
GuySartorelli approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 92ea9d1 into silverstripe:4 Aug 20, 2024
11 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/deprecate-widgets branch August 20, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli