Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a Data source URL: Fields should appear below collapsable component #129

Open
sachajudd opened this issue Jan 16, 2019 · 2 comments

Comments

@sachajudd
Copy link
Contributor

After some discussion with @clarkepaul we've decided that it might make more sense when editing a data source URL that the fields appear below the Data source title rather than above.

Quick mock up of what this might look like:
image

To do: Currently still deciding if it would need a background colour.

@robbieaverill
Copy link
Contributor

This could actually be a little tricky to achieve, because the field is a FormField and the title is a GridFieldComponent (part of a different FormField). We'd need to change the FormField into a GridFieldComponent probably, or move the title (GridFieldComponent) to be part of the FormField instead of where it is at the moment.

image

@ScopeyNZ
Copy link
Contributor

Yeah I think there's a search form toggle component that we might be able to leverage if we go for the latter solution (move the title to be part of a React component).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants