Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: pagination should use Bootstrap styles #177

Open
robbieaverill opened this issue Feb 5, 2019 · 4 comments
Open

Frontend: pagination should use Bootstrap styles #177

robbieaverill opened this issue Feb 5, 2019 · 4 comments

Comments

@robbieaverill
Copy link
Contributor

image

We should use Bootstrap button styles for the pagination.

Something like this: https://getbootstrap.com/docs/3.3/components/#default-example

Perhaps we could also make the two links in the screenshot into action buttons too.

@robbieaverill
Copy link
Contributor Author

PR at #192

@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Feb 11, 2019

#192 is merged but I think there's a further enhancement that can be done here to use the pagination component in some way:

https://reactstrap.github.io/components/pagination/

The silverstripe/silverstripe-registry component uses this already:

image

I still merged the PR as it felt like a worthy improvement. Should we raise this as a separate enhancement or do you think we should leave this issue open to accept another PR?

@robbieaverill
Copy link
Contributor Author

It's up to you. I don't think we necessarily need to match the Bootstrap component, but at least this doesn't look heinous any more

@robbieaverill
Copy link
Contributor Author

I'll change this into an enhancement for future

@robbieaverill robbieaverill removed this from the 1.0.0 milestone Feb 12, 2019
@robbieaverill robbieaverill added type/enhancement New feature or request change/minor and removed change/patch type/bug Something isn't working labels Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants