-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend: pagination should use Bootstrap styles #177
Comments
PR at #192 |
#192 is merged but I think there's a further enhancement that can be done here to use the pagination component in some way: https://reactstrap.github.io/components/pagination/ The silverstripe/silverstripe-registry component uses this already: I still merged the PR as it felt like a worthy improvement. Should we raise this as a separate enhancement or do you think we should leave this issue open to accept another PR? |
It's up to you. I don't think we necessarily need to match the Bootstrap component, but at least this doesn't look heinous any more |
I'll change this into an enhancement for future |
We should use Bootstrap button styles for the pagination.
Something like this: https://getbootstrap.com/docs/3.3/components/#default-example
Perhaps we could also make the two links in the screenshot into action buttons too.
The text was updated successfully, but these errors were encountered: