Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor link modals erroring for internal and anchor link types #2890

Closed
dizzystuff opened this issue Sep 23, 2023 · 3 comments
Closed

Editor link modals erroring for internal and anchor link types #2890

dizzystuff opened this issue Sep 23, 2023 · 3 comments

Comments

@dizzystuff
Copy link

After the 5.0.6 release, trying to add an internal or anchor link type is throwing a js error Uncaught TypeError: this.getRequireLinkText is not a function.

The method looks like it was removed in #2884 but references to it remain/were added.

Doesn't seem to matter where the HTMLEditorField is, replicating is adding text, highlighting the text, selecting Page on this site or Anchor on a page from the link dropdown.

@GuySartorelli
Copy link
Member

You need to update the silverstripe/admin module in your project as well, as that is where the entwine method is now defined.

@dizzystuff
Copy link
Author

@GuySartorelli I'm using the recipe-cms ^5.0.0, rather than including these core packages on a per-package basis. So I would've expected both updates to come through via a composer update. I'll take a look later today at why then I'm not getting the latest silverstripe/admin module, but might be worth checking the recipe then too for some oddity.

@GuySartorelli
Copy link
Member

Hmm. Can you please try a composer update -W?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants