OutOfBoundsException thrown when recipe-core isn't installed

[kinglozzer]

Module version(s) affected

5.2.0

Description

Appears to be a regression from #11157

If framework is installed without recipe-core, when it attempts to find the version of that package an OutOfBoundsException is thrown by Composer’s InstalledVersions::getPrettyVersion() as the package isn’t installed.

The old code would quietly skip the package if it wasn’t installed (it’d never be encountered in the loop):

silverstripe-framework/src/Core/Manifest/VersionProvider.php

Lines 191 to 195 in cca2f70

	foreach ($lockData['packages'] as $package) {
	if (in_array($package['name'], $modules ?? []) && isset($package['version'])) {
	$versions[$package['name']] = $package['version'];
	}
	}

Suggest we just add an if (InstalledVersions::isInstalled($module)) check to the new code before trying to fetch the pretty version:

silverstripe-framework/src/Core/Manifest/VersionProvider.php

Lines 191 to 193 in 97a8da8

	foreach ($modules as $module) {
	$versions[$module] = InstalledVersions::getPrettyVersion($module);
	}

How to reproduce

Install 5.2 without using recipe-core

Possible Solution

No response

Additional Context

No response

Validations

• Check that there isn't already an issue that reports the same bug
• Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

PRs

• FIX: OutOfBoundsException when recipe-core isn't installed (fixes #11197) #11199

[GuySartorelli]

PR merged. It will be automatically tagged by GitHub Actions