Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Don't expect class when its module isn't installed #11488

Merged
merged 1 commit into from
Dec 3, 2024
Merged

MNT Don't expect class when its module isn't installed #11488

merged 1 commit into from
Dec 3, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Dec 2, 2024 •
edited
Loading

Turns out SegmentField isn't always included.

Issue

This was referenced Dec 2, 2024
Closed
Merged
@GuySartorelli GuySartorelli changed the title MNT Don't use magic number in unit test MNT Don't expect class when its module isn't installed Dec 2, 2024
@GuySartorelli GuySartorelli force-pushed the pulls/6/validator-count branch from d708b07 to 6ae5e36 Compare December 2, 2024 23:49
@GuySartorelli
Copy link
Member Author

inmemorycache failure is unrelated

@emteknetnz emteknetnz merged commit 6cd38d2 into silverstripe:6 Dec 3, 2024
10 of 12 checks passed
@emteknetnz emteknetnz deleted the pulls/6/validator-count branch December 3, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz