Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP Update JS dependencies #108

Merged
merged 1 commit into from
Nov 20, 2024
Merged

DEP Update JS dependencies #108

merged 1 commit into from
Nov 20, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Nov 18, 2024
Closed
3 tasks
@emteknetnz emteknetnz marked this pull request as ready for review November 19, 2024 04:42
@emteknetnz
Copy link
Member Author

Note that the failing endtoend test passes on the kitchen-sink ci run linked on the parent issue

GuySartorelli
GuySartorelli approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 69f4307 into silverstripe:5 Nov 20, 2024
10 of 11 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/js-minor-deps branch November 20, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli