Add clippy

[phifty]

In order to improve the code, clippy could help to remove some code smells.

[coopernurse]

Good idea. Looking at: https://github.com/Manishearth/rust-clippy#usage Is it as simple as adding this to Cargo.toml?

[dependencies]
clippy = "*"

[phifty]

Give it a try :-)

[coopernurse]

I tried it, but get a compilation error. I didn't see an obvious solution in the rust-clippy Github project. Any ideas?

james ~/src/rust-delix $ cargo test
    Updating registry `https://github.com/rust-lang/crates.io-index`
   Compiling clippy v0.0.35
/home/james/.cargo/registry/src/github.com-0a35038f75765ae4/clippy-0.0.35/src/lib.rs:1:1: 1:42 error: #[feature] may not be used on the stable release channel
/home/james/.cargo/registry/src/github.com-0a35038f75765ae4/clippy-0.0.35/src/lib.rs:1 #![feature(plugin_registrar, box_syntax)]
                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/james/.cargo/registry/src/github.com-0a35038f75765ae4/clippy-0.0.35/src/lib.rs:2:1: 2:40 error: #[feature] may not be used on the stable release channel
/home/james/.cargo/registry/src/github.com-0a35038f75765ae4/clippy-0.0.35/src/lib.rs:2 #![feature(rustc_private, collections)]
                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/james/.cargo/registry/src/github.com-0a35038f75765ae4/clippy-0.0.35/src/lib.rs:3:1: 3:40 error: #[feature] may not be used on the stable release channel
/home/james/.cargo/registry/src/github.com-0a35038f75765ae4/clippy-0.0.35/src/lib.rs:3 #![feature(num_bits_bytes, iter_arith)]

[coopernurse]

I missed this in the "Usage" section:

"Compiler plugins are highly unstable and will only work with a nightly Rust for now."

Perhaps we wait until some of the features it relies on are in a stable Rust release?

[phifty]

I guess it's better to wait. I'm currently using Rust 1.5.0 stable and it seems not reasonable to switch to nightly just for clippy. Let's keep this issue open, but may move it to the next milestone if clippy doesn't get stable.

[phifty]

Since clippy not gonna be available for the stable branch any time soon, it might make sense to add clippy in a way that it only runs, if delix is compiled with a nightly rust. The output from travis ci could be used than to get some lints.