Issue with pysmurf zero_biases wait functionality

[jlashner]

The beginning of a satp1 schedule failed with the error because the zero_biases is not actually waiting for set_biases to finish.

2024-01-11T22:29:36+0000 start called for uxm_relock
2024-01-11T22:29:36+0000 uxm_relock:97 Status is now "starting".
2024-01-11T22:29:36+0000 uxm_relock:97 Operation failed: set_biases is running.
2024-01-11T22:29:36+0000 uxm_relock:97 Status is now "done".
2024-01-11T22:29:36+0000 set_biases:96 Finished setting biases to 0
2024-01-11T22:29:36+0000 set_biases:96 Status is now "done".

Zero biases is implemented to call the set_biases tasks and wait to finish like this:

socs/socs/agents/pysmurf_controller/agent.py

Lines 903 to 916 in be59fa4

	@ocs_agent.param('bgs', default=None)
	def zero_biases(self, session, params):
	"""
	**Task** - Zeros TES biases for specified bias groups.
	Args
	-----
	bg: int, list, optional
	bg, or list of bgs to zero. If None, will zero all bgs.
	"""
	params['bias'] = 0
	self.agent.start('set_biases', params)
	self.agent.wait('set_biases')
	return True, 'Finished zeroing biases'

However now I'm not actually sure if the wait function will wait if running in a blocking-thread, since it is a generator w/ inline callbacks, meant to run in the main thread. The simplest fix is that this should probably just be a completely separate task and acquire the lock / zero the TES biases itself instead of passing params to set_biases

[mhasself]

You could blockingCallFromThread those and I guess that would work. You should check for and propagate error though. start and wait can each return errors.