Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Agents robust to connection dropouts #721

Open
6 of 48 tasks
BrianJKoopman opened this issue Aug 13, 2024 · 2 comments
Open
6 of 48 tasks

Make Agents robust to connection dropouts #721

BrianJKoopman opened this issue Aug 13, 2024 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@BrianJKoopman
Copy link
Member

BrianJKoopman commented Aug 13, 2024

Related to discussion #538, we need to make sure agents are robust against connection dropouts, whether that's a network interruption, serial connection dropout, or otherwise.

I'm making a single issue for this to avoid spamming 50+ individual issues. If you would like to contribute, read on!

Contributing

If you would like to work on "robustifying" an agent, please create an issue with a title like "Make <AGENT NAME> robust to connection dropouts" and assign yourself. This will help us keep track of which agents are actively being worked on, and which are up for grabs. I will link relevant issues/PRs in the list below.

When you're ready, PR your code changes and link the associated issue. Once merged I'll update the checklist below.

The focus of these change should be on the "main" processes within each agent, as these are most impacted by lack of connection related error handling. Bonus points if you update tasks to handle errors.

(If you know any of the agents to already be robust, please comment here.)

Robust Agents Checklist

  • ACTiCameraAgent
  • ACUAgent
  • BlueforsAgent
  • CrateAgent
  • CryomechCPAAgent Robustness #766
  • FlowmeterAgent
  • GeneratorAgent
  • Hi6200Agent
  • HWPBBBAgent
  • HWPGripperAgent
  • HWPPCUAgent - Improve robustness of hwp_pcu #797
  • HWPPicoscopeAgent
  • HWPPIDAgent
  • HWPPMXAgent
  • HWPSupervisor
  • ibootbarAgent
  • LabJackAgent
  • Lakeshore240Agent - #589
  • Lakeshore372Agent - #325
  • Lakeshore425Agent
  • MeinbergM1000Agent
  • MeinbergSyncboxAgent
  • PfeifferAgent
  • PfeifferTC400Agent
  • PysmurfController
  • PysmurfMonitor
  • SmurfTimingCardAgent
  • SupRsync
  • SynaccessAgent
  • UCSCRadiometerAgent
  • UPSAgent
  • VantagePro2Agent
  • WiregridActuatorAgent
  • WiregridEncoderAgent
  • WiregridKikusuiAgent
  • WiregridTiltSensorAgent

Lab-only Agents (lower priority)

  • FPGAAgent
  • FTSAerotechAgent
  • Lakeshore336Agent
  • Lakeshore370Agent
  • LATRtXYStageAgent
  • MagpieAgent
  • ScpiPsuAgent - #725
  • SmurfFileEmulator
  • SmurfStreamSimulator
  • SynthAgent
  • TektronixAWGAgent
  • ThorlabsMC2000BAgent
@BrianJKoopman
Copy link
Member Author

It sounds like there might be some hardware related issues contributing, but the HWPPIDAgent is one of the commonly crashing agents, and a good one to take a look at next for anyone interested. See https://github.com/simonsobs/chwp-discussions/discussions/21.

@davidvng
Copy link
Contributor

@BrianJKoopman the ibootbarAgent and the UPSAgent should already robust to connection dropouts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants