Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the new ESP32 LEDC library API #390

Closed
flowersauce opened this issue Mar 21, 2024 · 4 comments · Fixed by #410 or #414
Closed

Support for the new ESP32 LEDC library API #390

flowersauce opened this issue Mar 21, 2024 · 4 comments · Fixed by #410 or #414
Assignees
Labels
enhancement New feature or request must have A must have feature for the next release
Milestone

Comments

@flowersauce
Copy link

In the arduino-ESP32 v3.0.0, there have been changes to the LEDC library API. I kindly request your support in updating the simpleFOC library to accommodate these changes.
fb581440deef4f81d286f67641f8f9f6
https://docs.espressif.com/projects/arduino-esp32/en/latest/migration_guides/2.x_to_3.0.html

@askuric
Copy link
Member

askuric commented Mar 21, 2024

Ok, the time is come, the v3.0.0 is released officially. :)

This release introduces a lot of braking changes. It will be our priority for the next release, but as there will be one release coming very soon 2.3.3. this will probably not be a part of it.
However, in the next few weeks you should have it supported in the dev branch at least

@askuric askuric transferred this issue from simplefoc/Arduino-FOC-drivers Mar 21, 2024
@askuric askuric added the enhancement New feature or request label Mar 21, 2024
@askuric
Copy link
Member

askuric commented Mar 21, 2024

I'd like to keep this issue open until we actually do support the v3.0.0!

@askuric askuric reopened this Mar 21, 2024
@runger1101001
Copy link
Member

It seems to me its still an alpha release?

It hasn't made it into the regular esp32 support of PlatformIO yet either. It was a bit of a pain to get it working, but after finding the right URL for the tasmota version of the framework I have PlatformIO compiling and running code on ESP32-C6 :-)

As far as I am aware Arduino IDE users also still have to reference the dev version of the boards manager URL?

So while I completely agree that we need to work on the support for it, and soon, I think we have to choose the moment to merge it to the main release carefully, so as not to break compatibility for a lot of users.

@askuric askuric self-assigned this Jun 7, 2024
@askuric askuric added the must have A must have feature for the next release label Jun 7, 2024
@askuric askuric added this to the 2.3.4_Release milestone Jun 8, 2024
@askuric
Copy link
Member

askuric commented Jul 22, 2024

In the new release v2.3.4

@askuric askuric closed this as completed Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request must have A must have feature for the next release
Projects
None yet
3 participants