Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytorch implementation #1

Open
rfarouni opened this issue Aug 31, 2018 · 4 comments
Open

Pytorch implementation #1

rfarouni opened this issue Aug 31, 2018 · 4 comments

Comments

@rfarouni
Copy link

Thanks for your great contribution. I really enjoyed reading the paper. I hope you do not mind me asking, but are there any plans for implementing the code in Pytorch? Although I am pretty familiar with Tensorflow, I find TF's declarative mode and static graph design philosophy a major flaw for research purposes, where flexibility, ease of debugging, and clarity of code tend to be more important considerations for some, especially for those researchers who would want to build upon, incorporate, or modify existing code.

@hannaml
Copy link
Contributor

hannaml commented Aug 31, 2018

Glad you enjoyed the paper! A numba implementation with a scikit-learn-like interface is already in the works, which will hopefully address many of the issues you listed. I plan to benchmark it against the tensorflow implementation, and will definitely look into pytorch if the performance difference is too onerous.

@rfarouni
Copy link
Author

rfarouni commented Sep 4, 2018

Thank you for your reply!

@hannaml
Copy link
Contributor

hannaml commented Dec 9, 2018

I just merged a numba implementation which may address your concerns. In addition, it is much faster an memory efficient than the previous tensorflow implementation, and has a pretty clear (I think) scikit-learn-like API interface. I'll be posting some API tutorials soon, but a CLI walkthrough is already up.

@rfarouni
Copy link
Author

Impressive work. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants