From c260e11cd0a85d260ffa8802b97c689dca547179 Mon Sep 17 00:00:00 2001 From: bhtowles Date: Wed, 1 May 2024 15:52:23 -0500 Subject: [PATCH] Revert accidental commit to main (#189) * Update orders stream for interrupted sync again * Revert "Update orders stream for interrupted sync again" This reverts commit 6921131db1fe6e1a5073a392d98559f5eecb39f0. * Push fix the correct way this time, update int sync orders stream * Fix if elif else bug --- tests/test_interrupted_sync.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/test_interrupted_sync.py b/tests/test_interrupted_sync.py index 508c7cca..d34aff54 100644 --- a/tests/test_interrupted_sync.py +++ b/tests/test_interrupted_sync.py @@ -200,9 +200,12 @@ def test_run(self): # This is the expected behaviour for shopify as they are using date windowing # TDL-17096 : Resuming bookmark value is getting assigned from execution time # rather than the actual bookmark time for some streams. - # TODO orders and transactions streams are equal, confirm this behavior is correct - if stream == 'transactions' or stream == 'orders': + # TODO transactions stream has equal bookmarks, orders stream has shown both equal + # and greater than bookmark behavior, confirm if this is correct + if stream == 'transactions': self.assertEqual(resuming_bookmark_value, first_bookmark_value) + elif stream == 'orders': + self.assertGreaterEqual(resuming_bookmark_value, first_bookmark_value) else: self.assertGreater(resuming_bookmark_value, first_bookmark_value)