-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 tag routes #4
Comments
I recall tags being part of v1 maybe? https://github.com/singularityhub/sregistry/blob/a076fc15c1322fa2e145067c38825c8575168b56/shub/apps/library/urls.py#L64. For the updated version I think tagging was a bit of an afterthought - like do the whole interaction first and then tell the registry the tag to apply. Ping @dtrudg in case he doesn't see this (he will know the right person to ask!) In terms of what should be part of the spec here, I would say endpoints that are essential for the main push pull, and then implementations are free to vary from that. |
I believe that the omission of the The general intent was for the OpenAPI spec file to list the required stable set of endpoints, and not to include things that may have been less than perfectly stable across versions of our (private) server implementations. There are definitely pieces of scs-library-client code that have been added, but might be supporting functionality that was later deprecated. For various reasons, the Singularity client side might have to cope with behavior around these (hence they are still represented in scs-library-client code)... but a third party server shouldn't have to implement them. Pining @tri-adam to see if there's any more context we can add here. |
so the safer bet would be to report version 2.0.0-alpha.1 like in Line 56 in 0190907
|
I was wondering about the /v2/tags routes that are used in the scs-library-client:
https://github.com/sylabs/scs-library-client/blob/eeab0e8dd3a70c3b0d448e7fc0768db67b3646ad/client/api.go#L271
https://github.com/sylabs/scs-library-client/blob/eeab0e8dd3a70c3b0d448e7fc0768db67b3646ad/client/api.go#L243
They're also missing in the openapi.yml, are they not for "public consumption"? I've implemented them in hinkskalle, it's been a while, I think it was because when you report api version 2.0.0-alpha.2 singularity uses this to get/set arch-specific tags.
The text was updated successfully, but these errors were encountered: