Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relase tagging #546

Closed
systemcrash opened this issue Feb 22, 2024 · 4 comments
Closed

relase tagging #546

systemcrash opened this issue Feb 22, 2024 · 4 comments

Comments

@systemcrash
Copy link
Contributor

I know release tagging isn't everyone's favourite thing to do, but the 1.4.59 release tagged in November has assets fresh from a few days ago... confusing:

Screenshot 2024-02-22 at 16 59 20

Is this intended? That the latest versions inherits all the latest changes until... the next successive version?

Your GH action for PR #545 logs this:

Run boxpositron/[email protected]
Found 4 asset(s)
homer-app
homer-app-1.4.59-amd64.deb
homer-app-1.4.59-amd64.rpm
homer-ui-1.4.59.tgz
Resolving tag
Release exists, overwriting assets.
Overwriting homer-app
Uploaded homer-app
Overwriting homer-app-1.4.59-amd64.deb
Uploaded homer-app-1.4.59-amd64.deb
Overwriting homer-app-1.4.59-amd64.rpm
Uploaded homer-app-1.4.59-amd64.rpm
Overwriting homer-ui-1.4.59.tgz
Uploaded homer-ui-1.4.59.tgz

@lmangani
Copy link
Member

lmangani commented Feb 22, 2024

That's more or less the current status indeed. The CI/Release pipeline uses this floating release as a hooking point and not as a distribution medium for our setups which are all package repository based or container based. If this is important and useful we can of course create new releases instead, but in order to do so we should move this last remaining pipeline to github actiions.

@systemcrash
Copy link
Contributor Author

systemcrash commented Feb 22, 2024

Just let the releaser auto-increment the version number when new features get added or PRs get merged, rather than keep adding features to the latest version release. master/latest is fine with everything new going in there. But nailing an image to a particular release version should be an option (so that e.g. checksums match).

steps:
- uses: actions/checkout@v3
- id: tag_bump
name: Bump version and push tag
uses: anothrNick/[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
DEFAULT_BUMP: none
BRANCH: master

DEFAULT_BUMP should be something like patch

https://github.com/anothrNick/github-tag-action

@systemcrash
Copy link
Contributor Author

Check also the warnings for your GH actions which run, and bump some of those actions to newer versions.

@adubovikov
Copy link
Member

I hope now it works as expected:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants