Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the MinterAmm an ERC20 token and use it as the LPToken #40

Open
zareth-san opened this issue May 5, 2021 · 1 comment
Open

Make the MinterAmm an ERC20 token and use it as the LPToken #40

zareth-san opened this issue May 5, 2021 · 1 comment

Comments

@zareth-san
Copy link
Contributor

Currently we deploy a separate ERC20 token for each AMM pool to track LP ownership. Meanwhile, Uniswap simply makes the pool an ERC20 token, and uses that as the pool token. We should change the AMM to do this as well since it will save on gas (no contract creation, no cross-contract ERC20 calls) and it will make the subgraph mapping simpler.
@siren-tamer
Copy link
Contributor

Is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@siren-tamer @zareth-san