Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library is not OSGi-compliant #91

Open
pshirshov opened this issue Jul 27, 2015 · 4 comments
Open

Library is not OSGi-compliant #91

pshirshov opened this issue Jul 27, 2015 · 4 comments

Comments

@pshirshov
Copy link

You should OSGify library. It's easy with typesafe sbt-osgi plugin.

Here is example: https://github.com/typesafehub/scala-logging/pull/37/files

@stempler
Copy link

stempler commented Jun 1, 2016

Also stumbled upon this - note that the OSGi manifest informations were there in previous versions, e.g. 1.1.6 of parboiled-java includes the headers, 1.1.7 does not. Just wrapping with default settings is probably not enough, for me it was important that parboiled-java is a fragment of parboiled-core (Fragement-Host header). For parboiled-scala probably the same applies.

@sirthias
Copy link
Owner

sirthias commented Jun 1, 2016

OSGi support is increasingly a non-goal for me.
Establishing and maintaining it properly is not something that I am sufficiently qualified for.
Also, my impression is that the share of users that depend on or ask for it is steadily decreasing.
Sorry guys...

@bdkent
Copy link

bdkent commented Jun 13, 2016

Just for the record, I was also effected by the lack of OSGi support in 1.1.7.

@kenwenzel
Copy link
Contributor

PR #132 fixes a class loader problem with ASM ClassWriter to use Parboiled 1.3.0 in OSGi containers.

I would suggest to create a single OSGi bundle for the Java version as in https://github.com/komma/komma/blob/15aa9321d0f2e7a2f29f6677ed6b5f296505415f/libraries-p2/parboiled/pom.xml

This avoids problems with fragments (Fragment-Host header) or split packages...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants