From 807830e3bb6ebea191f9f3e5152ead6811b2f664 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sun, 23 Oct 2022 14:59:43 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- node_cli/operations/common.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/node_cli/operations/common.py b/node_cli/operations/common.py index 5fd6bef7..d0084ea7 100644 --- a/node_cli/operations/common.py +++ b/node_cli/operations/common.py @@ -83,4 +83,23 @@ def configure_flask(): def unpack_backup_archive(backup_path: str) -> None: logger.info('Unpacking backup archive...') with tarfile.open(backup_path) as tar: - tar.extractall(path=G_CONF_HOME) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=G_CONF_HOME)