Invalid gas computation/fork block in estimateGas

[dimalit]

estimateGas uses DefaultSchedule:
int64_t lowerBound = Transaction::baseGasRequired( !_dest, &_data, EVMSchedule() ); (libethereum/ClientBase.cpp:118)
`
This can lead to overestimation of gas for transactions with non-zero data.

Example:

1. Send simple transfer transaction with 54000 bytes of data.
2. It should require 21000+54000*68=3.6M of gas - and this is checked during eth_sendRawTransaction call
3. In fact, it will consume around 800k of gas.
4. Reason: skaled uses coefficient 16, but estimateGas uses 68.

See also #1745

[kladkogex]

This will need to be done as a patch so the state roots do not diverge

[dimalit]

For QA: need test transaction ('data' field) that has incorrect gas estimation.

[dimalit]

EvmSchedule chronology:

Default: exceptionalFailedCodeDeposit=true, haveDelegateCall = true, txCreateGas = 53000

Frontier: exceptionalFailedCodeDeposit=false, haveDelegateCall = false, txCreateGas = 21000

Homestead = Default

EIP150 = Homestead and: 150mode, extcodesizeGas = 700, extcodecopyGas = 700, balanceGas = 400, sloadGas = 200, callGas = 700, suicideGas = 5000

EIP158 = EIP150 and: 158mode, expByteGas = 50, maxCodeSize = 1024 * 64

Byzantium = EIP158 and: haveRevert, haveReturnData, haveStaticCall, blockRewardOverwrite = { 3 * ether };

EWASM = Byzantium and: maxCodeSize = std::numeric_limits< unsigned >::max

Constantinople = Byzantium and: haveCreate2,haveBitwiseShifting,haveExtcodehash,eip1283Mode,blockRewardOverwrite = { 2 * ether };

ConstantinopleFix = Constantinople and eip1283Mode=false

Istanbul = ConstantinopleFix and: txDataNonZeroGas = 16, sloadGas = 800, balanceGas = 700, extcodehashGas = 700,haveChainID = true, haveSelfbalance = true, sstoreUnchangedGas = 800;

[DmytroNazarenko]

skaled: 3.18.0-beta.0
patch: correctForkInPowPatchTimestamp

[oleksandrSydorenkoJ]

Verified on Regression network
skaled: 3.18.0-beta.0
patch: correctForkInPowPatchTimestamp

Skale chain: aged-wry-finished-skale

Updated node
gas estimate is 872792 and equals to gasUsed 872792

2024-01-30 10:32:00.970: Current gas price = 100000
2024-01-30 10:32:00.970: Will call w3.eth.getTransactionCount()...
2024-01-30 10:32:01.380: User 0x71cBE3fedE33905d4D1Bf2Bd51f9d4A62375e659 balance is 999999984369999955943739400000
Index is  1521
TCNT is  1521
gas estimate is  872792
2024-01-30 10:32:02.408: Sending signed method call transaction...
2024-01-30 10:32:05.788: Result receipt: { blockHash: "0x35b06696f8976da85710d09284e1c476a0d3e4d49d6fe270caab1a9524634d19", blockNumber: 46494, contractAddress: null, cumulativeGasUsed: 872792, from: "0x71cbe3fede33905d4d1bf2bd51f9d4a62375e659", gasUsed: 872792, logs: [], logsBloom: "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", status: true, to: "0xa68f946090c600eda6f139783077ee802afeb990", transactionHash: "0xb7c742f0d4e568282acfe1c04f14a5c9de97f097705c43dfe964c2218bf88153", transactionIndex: 0}

not updated node (3.17.1):
gas estimate is 3641116 and it is bigger than gasUsed 872792

gas estimate is  3641116
2024-01-30 10:33:29.554: Sending signed method call transaction...
2024-01-30 10:33:39.076: Result receipt: { blockHash: "0x1d9196077b85080bf2368e4570fdd13365999a50a92d7bfe047c35afb8a1320b", blockNumber: 46501, contractAddress: null, cumulativeGasUsed: 872792, from: "0x71cbe3fede33905d4d1bf2bd51f9d4a62375e659", gasUsed: 872792, logs: [], logsBloom: "0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000", status: true, to: "0xa68f946090c600eda6f139783077ee802afeb990", transactionHash: "0x4e51301a93defad2c510e89dd173352773e591a49977169c7cd099acdcf4c41e", transactionIndex: 0}