Enhancement/2004 add patch timestamp debug api #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PropzSaladaz
requested review from
DmytroNazarenko and
kladkogex
as code owners
|
SUGGESTIONS BEFORE MERGE:
|
DmytroNazarenko
requested changes
Jan 22, 2025
Comment on lines
+29
to
+30
| else if ( _patchName == "SelfdestructStorageLimitPatch" ) | ||
| return SchainPatchEnum::SelfdestructStorageLimitPatch; |
There was a problem hiding this comment.
What is the purpose of this patch?
There was a problem hiding this comment.
This line was missing in the original code. We had the SchainPatchEnum::SelfdestructStorageLimitPatch enum variant defined, but not the convertion from its string value to the enum variant in this function (which converts a string to the corresponding SchainPatchEnum variant. So I added the missing conversion.
Comment on lines
2798
to
2810
| std::vector< int > patchTimestamps; | ||
|
|
||
| // Set custom config file & create timestamps for each patch | ||
| size_t numPatches = static_cast< size_t >( SchainPatchEnum::PatchesCount ); | ||
| for (size_t patch = 0; patch < numPatches ; patch++ ) { | ||
| SchainPatchEnum patchEnum = static_cast< SchainPatchEnum >( patch ); | ||
| int ts = patch + 1000; // just to offset from the default values (0, 1) | ||
| patchTimestamps.push_back(ts); | ||
|
|
||
| std::string patchName = getPatchNameForEnum(patchEnum) + "Timestamp"; | ||
| patchName[0] = tolower( patchName[0] ); | ||
| configJson["skaleConfig"]["sChain"][patchName] = ts; | ||
| } |
There was a problem hiding this comment.
Better to use time_t type instead of int, as patchTimestamps are time_t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Example call:
Example response:
{"id":1205,"jsonrpc":"2.0","result":{"contractStoragePatchTimestamp":1681732800,"contractStorageZeroValuePatchTimestamp":1681128000,"correctForkInPowPatchTimestamp":1710331200,"eIP1559TransactionsPatchTimestamp":1721818800,"externalGasPatchTimestamp":1727712000,"fastConsensusPatchTimestamp":1721822400,"flexibleDeploymentPatchTimestamp":1721826000,"powCheckPatchTimestamp":1702296000,"precompiledConfigPatchTimestamp":1710331200,"pushZeroPatchTimestamp":1710331200,"revertableFSPatchTimestamp":1681473600,"selfdestructStorageLimitPatchTimestamp":0,"skipInvalidTransactionsPatchTimestamp":1702382400,"storageDestructionPatchTimestamp":1702393200,"verifyBlsSyncPatchTimestamp":1721829600,"verifyDaSigsPatchTimestamp":1681300800}}Tests
Fixes #2004