Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove debug library builds from release #1900

Open
kladkogex opened this issue May 16, 2024 · 2 comments · Fixed by #1969, #2013 or #2014 · May be fixed by #2072 or skalenetwork/libBLS#220
Open

Remove debug library builds from release #1900

kladkogex opened this issue May 16, 2024 · 2 comments · Fixed by #1969, #2013 or #2014 · May be fixed by #2072 or skalenetwork/libBLS#220
Assignees
@olehnikolaiev
Labels
Technical debt
Milestone
SKALE 4.0

Comments

@kladkogex
Copy link
Collaborator

kladkogex commented May 16, 2024 •
edited
Loading

It looks like the release build includes some libraries in debug (ZeroMQ) mode.

This needs to be fixed since it may affects performance

We need a check at the end of the build that the executable does not have debug symbols

image
@kladkogex kladkogex added the bug Something isn't working label May 16, 2024
@kladkogex kladkogex added this to the SKALE 2.5 milestone May 16, 2024
@kladkogex kladkogex self-assigned this May 16, 2024
@PolinaKiporenko PolinaKiporenko moved this from To Do to Ready For Pickup in SKALE Engineering 🚀 May 17, 2024
@kladkogex kladkogex assigned dimalit and unassigned dimalit and kladkogex May 17, 2024
@DmytroNazarenko DmytroNazarenko added Technical debt and removed bug Something isn't working labels Aug 7, 2024
@dimalit
Copy link
Contributor

dimalit commented Aug 7, 2024

Stan, we use RelsWithDeb info build type, so debug symbols are expected.

This was linked to pull requests Aug 23, 2024
SKALED-1900 Release build #1967
Closed
SKALED-1900 release build with separate debug info #1969
Merged
@DmytroNazarenko DmytroNazarenko linked a pull request Sep 27, 2024 that will close this issue
Revert "SKALED-1900 release build with separate debug info" #2013
Merged
@dimalit dimalit linked a pull request Sep 30, 2024 that will close this issue
SKALED-1900 release build with separate debug info #2014
Merged
@EvgeniyZZ EvgeniyZZ moved this from QA to Done in SKALE Engineering 🚀 Nov 5, 2024
@PolinaKiporenko PolinaKiporenko moved this from Done to To Do in SKALE Engineering 🚀 Dec 4, 2024
@PolinaKiporenko
Copy link
Contributor

Part of implemented changes not merged accordingly , should be included in next release

@PolinaKiporenko PolinaKiporenko modified the milestones: SKALE 3.1, SKALE 4.0 Dec 4, 2024
@olehnikolaiev olehnikolaiev moved this from To Do to In Progress in SKALE Engineering 🚀 Jan 6, 2025
olehnikolaiev added a commit that referenced this issue Jan 7, 2025
@olehnikolaiev
#1900 enhance release build
d0e6d72
olehnikolaiev added a commit that referenced this issue Jan 8, 2025
@olehnikolaiev
#1900 disable asserts in RelWithDebInfo mode
f1fbbc8
olehnikolaiev added a commit that referenced this issue Jan 8, 2025
@olehnikolaiev
#1900 build deps without debug symbols
1b4899e
olehnikolaiev added a commit that referenced this issue Jan 8, 2025
@olehnikolaiev
#1900 format code
fe5071c
olehnikolaiev added a commit that referenced this issue Jan 8, 2025
@olehnikolaiev
#1900 enhance the build
26fc035
olehnikolaiev added a commit that referenced this issue Jan 8, 2025
@olehnikolaiev
#1900 disable asserts
6a37913
olehnikolaiev added a commit that referenced this issue Jan 8, 2025
@olehnikolaiev
#1900 build deps without debug symbols
ade3bd6
olehnikolaiev added a commit that referenced this issue Jan 8, 2025
@olehnikolaiev
#1900 format code
2302722
@olehnikolaiev olehnikolaiev moved this from In Progress to Code Review in SKALE Engineering 🚀 Jan 8, 2025
@olehnikolaiev olehnikolaiev linked a pull request Jan 8, 2025 that will close this issue
Open
@olehnikolaiev olehnikolaiev linked a pull request Jan 8, 2025 that will close this issue
Feature/1900 remove debug symbols release #2072
Open
@olehnikolaiev olehnikolaiev linked a pull request Jan 9, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olehnikolaiev olehnikolaiev

Labels
Technical debt
Projects
SKALE Engineering 🚀
Status: Code Review
Milestone
SKALE 4.0
5 participants
@dimalit @kladkogex @DmytroNazarenko @olehnikolaiev @PolinaKiporenko