feat(react-ui): Add shadow dom environment supports #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshatikhin
force-pushed
the
shadow-dom
branch
13 times, most recently
from
95aa78c to
48840c3
Compare
mshatikhin
force-pushed
the
shadow-dom
branch
7 times, most recently
from
6c4e746 to
c7cae9f
Compare
mshatikhin
force-pushed
the
shadow-dom
branch
2 times, most recently
from
556f33a to
aaa6c7e
Compare
mshatikhin
force-pushed
the
shadow-dom
branch
2 times, most recently
from
430bdb1 to
1ac8e18
Compare
lossir
reviewed
Jul 27, 2024
|
|
||
| const scope = new Array(Upgrade.getSpecificityLevel()).fill(`.${REACT_UI_PREFIX}`).join(''); | ||
|
|
||
| export const { flush, hydrate, cx, merge, getRegisteredStyles, injectGlobal, keyframes, css, sheet, cache } = | ||
| export const getEmotion = (container?: HTMLElement | null, key?: string): Emotion => |
There was a problem hiding this comment.
Для настройки CSP понадобиться ещё nonce...
Думаю, стоит сделать аргумент объектом, и мержить с дефолтными настройками в createEmotion().
В каком статусе этот ПР, кст?)
mshatikhin
force-pushed
the
shadow-dom
branch
2 times, most recently
from
052e1de to
7d589c7
Compare
mshatikhin
force-pushed
the
shadow-dom
branch
7 times, most recently
from
7c8f3cd to
bbc4310
Compare
mshatikhin
force-pushed
the
shadow-dom
branch
9 times, most recently
from
32865b0 to
cb40b44
Compare
mshatikhin
force-pushed
the
shadow-dom
branch
3 times, most recently
from
957e78b to
044e274
Compare
mshatikhin
changed the title
mshatikhin
changed the title
mshatikhin
force-pushed
the
shadow-dom
branch
5 times, most recently
from
107211c to
9cf7dcc
Compare
mshatikhin
force-pushed
the
shadow-dom
branch
from
9cf7dcc to
6c19c87
Compare
mshatikhin
force-pushed
the
shadow-dom
branch
from
6c19c87 to
c2bf15a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Проблема
Если рендерить контролы внутри окружения Shadow Dom, то потеряются стили и перестанут работать контроллы (выпадашки, модалки). Использование окружения Shadow Dom важно для встраиваемых виджетов, они должны быть максимально изолированы.
Решение
Ссылки
Задача - https://yt.skbkontur.ru/issue/IF-1655
Чек-лист перед запросом ревью
Добавлены тесты на все изменения
⬜ unit-тесты для логики
⬜ скриншоты для верстки и кросс-браузерности
⬜ нерелевантно
Добавлена (обновлена) документация
⬜ styleguidist для пропов и примеров использования компонентов
⬜ jsdoc для утилит и хелперов
⬜ комментарии для неочевидных мест в коде
⬜ прочие инструкции (
README.md,contributing.mdи др.)⬜ нерелевантно
Изменения корректно типизированы
⬜ без использования
any(см. PR2856)⬜ нерелевантно
Прочее
⬜ все тесты и линтеры на CI проходят
⬜ в коде нет лишних изменений
⬜ заголовок PR кратко и доступно отражает суть изменений (он попадет в changelog)