Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting warning on a build process #139

Closed
anatoliy-t7 opened this issue Dec 31, 2024 · 4 comments · Fixed by #150
Closed

Getting warning on a build process #139

anatoliy-t7 opened this issue Dec 31, 2024 · 4 comments · Fixed by #150
Labels
bug Something isn't working

Comments

@anatoliy-t7
Copy link

Current Behavior

"useFloating", "useRole", "useClick", "useDismiss", "useInteractions" and "useHover" are imported from external module "@floating-ui/dom" but never used in "node_modules/@skeletonlabs/floating-ui-svelte/dist/components/FloatingArrow/FloatingArrow.svelte", "node_modules/@skeletonlabs/floating-ui-svelte/dist/hooks/useFloating/index.svelte.js" and "node_modules/@skeletonlabs/floating-ui-svelte/dist/index.js".
"getWindow" and "getOverflowAncestors" are imported from external module "@floating-ui/utils/dom" but never used in "node_modules/@skeletonlabs/floating-ui-svelte/dist/utils/is-typable-element.js", "node_modules/@skeletonlabs/floating-ui-svelte/dist/hooks/useDismiss/index.svelte.js", "node_modules/@skeletonlabs/floating-ui-svelte/dist/hooks/useClick/index.svelte.js", "node_modules/@skeletonlabs/floating-ui-svelte/dist/utils/dom.js", "node_modules/@skeletonlabs/floating-ui-svelte/dist/hooks/useFocus/index.svelte.js" and "node_modules/@skeletonlabs/floating-ui-svelte/dist/hooks/useHover/index.svelte.js".

Expected Behavior

No response

Steps To Reproduce

No response

Link to Reproduction / Stackblitz

No response

More Information

npmPackages:
floating-ui-svelte: 0.3.2
sveltejs/kit: 2.15.1
svelte: 5.16.0
vite: 6.0.6

@anatoliy-t7 anatoliy-t7 added the bug Something isn't working label Dec 31, 2024
@Hugos68
Copy link
Collaborator

Hugos68 commented Jan 1, 2025

Hello @anatoliy-t7, thanks for reporting this, however, I'm unable to recreate this: https://github.com/Hugos68/floating-ui-svelte-test. I only ran vite build, you didn't gave us steps to reproduce so it's a bit of guessing work how you got this error. Am I supposed to see it when running vite build?

Note: I am on a slightly newer version, you could try updating your version to see if that fixes things as we've had quite an internal cleanup the past few days.

@anatoliy-t7
Copy link
Author

Hi @Hugos68
Thank you for getting back to me.
I tested your repo https://github.com/Hugos68/floating-ui-svelte-test.
It is true if I use pnpm there is no warning about it, but it shows if I use npm.

P.S. I updated it to the last version.

@Hugos68
Copy link
Collaborator

Hugos68 commented Jan 2, 2025

I'll try npm then, thanks for clarifying!
I'll get back to you after debugging.

@Hugos68
Copy link
Collaborator

Hugos68 commented Jan 2, 2025

@anatoliy-t7 Ok I'm able to recreate but I really don't understand the issue, we're not doing what it's saying, we never use getOverflowAncestors or getWindow anywhere. I feel like this is a bug in Vite 6 as it only happens in Vite 6 and not Vite 5. Perhaps create in an issue in their repo? I'm going to close this out as the warning is incorrect.

@Hugos68 Hugos68 closed this as completed Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants