You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it would be good to have rerun send os.Interrupt to the application that is running. The go runtime will kill itself unless signal.Notify(..) was called for the os.Interrupt signal. We could add a timeout and do proc.Kill anyway when the graceful shutdown is taking too long. On the other hand, how to define "too long"? I think if a graceful shutdown should be able to take it's time. When the application just doesn't do a graceful shutdown on signal os.Interrupt, it has a bug that should be asap fixed by the dev. Thoughts?
The text was updated successfully, but these errors were encountered:
One could argue to use SIGTERM, instead of os.Interrupt (SIGINT). However, SIGTERM is not abstracted by Go's os package. I think it isn't cross-platform supported....
afaik: os.Interrupt is.
I'm now using rerun for an application that performs graceful shutdown on the interrupt signal.
Rerun kill's the process directly, without any grace.
Happens here: https://github.com/skelterjohn/rerun/blob/master/rerun.go#L91
I think it would be good to have rerun send os.Interrupt to the application that is running. The go runtime will kill itself unless signal.Notify(..) was called for the os.Interrupt signal. We could add a timeout and do proc.Kill anyway when the graceful shutdown is taking too long. On the other hand, how to define "too long"? I think if a graceful shutdown should be able to take it's time. When the application just doesn't do a graceful shutdown on signal os.Interrupt, it has a bug that should be asap fixed by the dev. Thoughts?
The text was updated successfully, but these errors were encountered: