Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgo save fails when GO15VENDOREXPERIMENT style layout is used along with multi-gopath layout. #13

Open
saml opened this issue May 16, 2016 · 1 comment

Comments

@saml
Copy link

saml commented May 16, 2016

wgo save errors out when there's more than one go15vendorexperiment style trees under vendor/

For example, given below directories, wgo save fails:

# go15vendorexperiment
vendor/github.com/
vendor/golang.org/

# multi-gopath
vendor/pkg/
vendor/src/

Notes:

  • If there's only one go15vendorexperiment tree (vendor/github.com/ only without vendor/golang.org/), wgo save works.
  • If go15vendorexperiment trees are empty (vendor/github.com/ and vendor/golang.org/ are both empty), wgo save works.

Environment:

> go version
go version go1.6.2 linux/amd64
>  go env GOPATH
/home/saml/code

Reproducible steps:

# upgrade wgo
> wgo get -u github.com/skelterjohn/wgo

# create a test project foobar
> mkdir $GOPATH/src/foobar
> cd $GOPATH/src/foobar
> wgo init

# Below is important. 
# Looks like bug needs at least two trees under vendor/ to surface.
# One vendor/github.com and another vendor/golang.org
> wgo get github.com/gorilla/websocket
> wgo get golang.org/x/oauth2 
> cd vendor
> ln -s src/github.com github.com # cp -r is good as well
> ln -s src/golang.org golang.org
> cd ..
> wgo save
exit status 2
@bdandy
Copy link

bdandy commented Oct 19, 2016

As for me, I think that wgo should be completely migrated to go15vendorexperiment path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants