Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protocol messages to match v1 architecture #150

Open
7 of 8 tasks
haydn opened this issue Sep 9, 2021 · 0 comments · May be fixed by #155
Open
7 of 8 tasks

Update protocol messages to match v1 architecture #150

haydn opened this issue Sep 9, 2021 · 0 comments · May be fixed by #155
Assignees
@Mxchaeltrxn
Milestone
v0.4

Comments

@haydn
Copy link
Member

haydn commented Sep 9, 2021 •
edited by Mxchaeltrxn
Loading

These messages are currently handled in the src/editor/useCanvasConnection.js and src/canvas/useEditorConnection.js files:

  • sketchbook_status_request
  • sketchbook_status_response
  • sketchbook_render_layers_request
  • sketchbook_measure_layer_request
  • sketchbook_measure_layer_response

They need to be updated to match the protocol defined in #149:

  • Rename sketchbook_status_request to sketchbook_request:ping
  • Rename sketchbook_status_response to sketchbook_response:acknowledge
  • Rename sketchbook_render_layers_request to sketchbook_request:render
  • Update canvas to respond with sketchbook_response:acknowledge to a render request
  • Rename sketchbook_measure_layer_request to sketchbook_request:measure
  • Rename sketchbook_measure_layer_response to sketchbook_response:measure
  • Add id fields to all messages
  • Update the sketchbook_response:measure request to have a layer field
@haydn haydn added this to the v0.4 milestone Sep 9, 2021
@Mxchaeltrxn Mxchaeltrxn linked a pull request Sep 15, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mxchaeltrxn Mxchaeltrxn

Labels
None yet
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

Ref/request response sketchbook-js/sketchbook
2 participants
@haydn @Mxchaeltrxn