Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hyperlane Transfer Action Support #149

Merged
merged 11 commits into from
Nov 6, 2024

Conversation

NotJeremyLiu
Copy link
Member

@NotJeremyLiu NotJeremyLiu commented Nov 4, 2024

This PR

  • Implements a hyperlane remote transfer adapter contract, which takes in the coin sent to the contract along with the rest of the remote transfer metadata and calls the hyperlane warp route contract with it
  • Adds the hyperlane transfer action in the entry point contract, allowing an action or post swap action to be a hyperlane transfer
  • This is generally useful to allow 1-click hyperlane flows before we know the amount out of a swap

@NotJeremyLiu NotJeremyLiu changed the base branch from main to jl/action-support November 4, 2024 03:36
@NotJeremyLiu NotJeremyLiu requested a review from thal0x November 4, 2024 03:38
Base automatically changed from jl/action-support to main November 4, 2024 22:16
let asset: Asset = one_coin(&info)?.into();

// Create the Hyperlane remote transfer message
let msg = to_json_binary(&TransferRemote {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are you basing this type off of? Is it possibly an old version?

This is what the current type looks like:
https://github.com/hyperlane-xyz/cosmwasm/blob/main/packages/interface/src/warp/native.rs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thal0x I'm basing it off of this repo: https://github.com/many-things/cw-hyperlane, which seems to be the maintained one (I think the official hyperlane-xyz one is no longer updated)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's not confusing at all 😅

@NotJeremyLiu NotJeremyLiu merged commit e2bffe6 into main Nov 6, 2024
5 checks passed
@NotJeremyLiu NotJeremyLiu deleted the jl/hyperlane-transfer-action branch November 6, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants