Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish blog with GitHub pages #3

Closed
acka47 opened this issue Aug 24, 2021 · 15 comments · Fixed by #6
Closed

Publish blog with GitHub pages #3

acka47 opened this issue Aug 24, 2021 · 15 comments · Fixed by #6
Assignees
@acka47

Comments

@acka47
Copy link
Member

acka47 commented Aug 24, 2021 •
edited by fsteeg
Loading

See https://www.gatsbyjs.com/docs/how-to/previews-deploys-hosting/how-gatsby-works-with-github-pages/ for instructions on how to use gatsby with GitHub pages.

I think, we should

  • publish to the root subdomain
  • configure a reverse proxy so that post are published at https://blog.skohub.io

Functional review: @acka47
Code review: @fsteeg
katauber added a commit that referenced this issue Aug 25, 2021
@katauber
Publish to Github Pages via Github Actions when merging into main (#3)
04fae3a
@acka47
Copy link
Member Author

acka47 commented Aug 25, 2021

We decided to first publish to https://skohub-io.github.io and then set up the reverese proxy in a next step.

katauber added a commit that referenced this issue Aug 25, 2021
@katauber
Change deploy workflow to test Github Pages deployment (#3)
cf08c2c
katauber added a commit that referenced this issue Aug 25, 2021
@katauber
Fix siteURL in gatsby-config (#3)
2574318
katauber added a commit that referenced this issue Aug 25, 2021
@katauber
Add gatsby args to use pathPrefix in Github Actions (#3)
532ee0e
katauber added a commit that referenced this issue Aug 25, 2021
@katauber
Fix gatsby-args in Actions workflow (#3)
3095536
katauber added a commit that referenced this issue Aug 26, 2021
@katauber
Fix deploy branch and gatsby arg (#3)
bfe63bf
katauber added a commit that referenced this issue Aug 26, 2021
@katauber
Fix link to RSS Feed (#3)
ffb886a
katauber added a commit that referenced this issue Aug 26, 2021
@katauber
Deploy Pages only when push to main (#3)
34a94b7
@dr0i dr0i self-assigned this Aug 30, 2021
@dr0i
Copy link
Member

dr0i commented Aug 30, 2021 •
edited
Loading

@dr0i :

  • configure proxy
  • install SSL certificate

Asked IT to resolve blog.skohub.io to emphytos.

@dr0i
Copy link
Member

dr0i commented Aug 30, 2021 •
edited
Loading

Configured as proxy, note the missing certificate. While it looks ok, it is not: look in the browser's dev console for missing files. E.g. the file https://blog.skohub.io/skohub-blog/favicon-32x32.png?v=91b1901e405e1500f9b7569b85f1ad60 is missing while it works leaving out the /skohub-blog, see https://blog.skohub.io/favicon-32x32.png?v=91b1901e405e1500f9b7569b85f1ad60 . That's because of the proxy. It would be fixed if we could assure https://skohub-io.github.io/ to work (as claimed in #3 (comment)), not https://skohub-io.github.io/skohub-blog/ as it is atm.

@dr0i
Copy link
Member

dr0i commented Aug 31, 2021

note to self: may be the same problem as in metafacture/metafacture-playground#27. Check that out.

@katauber katauber removed their assignment Sep 1, 2021
dr0i added a commit that referenced this issue Sep 2, 2021
@dr0i
Add missing "npm install when building (#3)
ef72a61
dr0i added a commit that referenced this issue Sep 3, 2021
@dr0i
Remove pathPrefix "/skohub-blog" (#3)
5c7b700 
Don't build links with "skohub-blog" prefix as these would result in adding
that path to our publish site. As we use a subdomain "blog.skohub.io" we don't
want to need this.
@dr0i dr0i mentioned this issue Sep 3, 2021
Merged
@dr0i
Copy link
Member

dr0i commented Sep 3, 2021 •
edited
Loading

@acka47 forked, branched and deployed to my pages to test the setup. I think it's fine now with the pathPrefix removed. If you check the links: they lack the "/skohub-blog part.

@dr0i
Copy link
Member

dr0i commented Sep 3, 2021

Also configured this setup into the proxy - test it : https://blog.skohub.io/ .

@dr0i dr0i assigned acka47 and unassigned dr0i Sep 3, 2021
@acka47
Copy link
Member Author

acka47 commented Sep 3, 2021

Looks fine. The rel=canonical links should be configured differently, though. Currently they are pointing to GitHub pages, e.g. at https://blog.skohub.io/2020-10-09-skohub-apconf/: <link rel="canonical" href="https://skohub-io.github.io/skohub-blog/2020-10-09-skohub-apconf/". This should be <link rel="canonical" href="https://blog.skohub.io/2020-10-09-skohub-apconf/" instead. Maybe we could use https://www.gatsbyjs.com/plugins/gatsby-plugin-canonical-urls/ for this. Assigning @katauber .

@acka47 acka47 assigned katauber and unassigned acka47 Sep 3, 2021
@katauber
Copy link
Member

katauber commented Sep 3, 2021

Looks fine. The rel=canonical links should be configured differently, though. Currently they are pointing to GitHub pages, e.g. at https://blog.skohub.io/2020-10-09-skohub-apconf/: <link rel="canonical" href="https://skohub-io.github.io/skohub-blog/2020-10-09-skohub-apconf/". This should be <link rel="canonical" href="https://blog.skohub.io/2020-10-09-skohub-apconf/" instead. Maybe we could use https://www.gatsbyjs.com/plugins/gatsby-plugin-canonical-urls/ for this. Assigning @katauber .

This plugin is already installed, I will adjust the gatsby-conf.js to the right url.

katauber added a commit that referenced this issue Sep 3, 2021
@katauber
Fix url especially for canonical links (#3)
17ad323
@fsteeg fsteeg linked a pull request Sep 7, 2021 that will close this issue
3 publish blog #6
Merged
@katauber katauber removed their assignment Sep 7, 2021
dr0i added a commit that referenced this issue Sep 10, 2021
@dr0i
Add .editorconfig to maintain consistent coding style (#3)
489690f 
This config file of format rules can be applied by many IDEs and editors,
e.g. codium and vim. Some need an extra plugin for that, like the latter.
dr0i added a commit that referenced this issue Sep 10, 2021
@dr0i
Add .editorconfig to maintain consistent coding style (#3)
d0b56ee 
This config file of format rules can be applied by many IDEs and editors,
e.g. codium and vim. Some need an extra plugin for that, like the latter.
@dr0i dr0i closed this as completed in #6 Sep 10, 2021
@dr0i
Copy link
Member

dr0i commented Sep 10, 2021

Merged #6 into main to trigger a rebuild of the pages.
Reopening this issue for functional review.

@dr0i dr0i reopened this Sep 10, 2021
@dr0i
Copy link
Member

dr0i commented Sep 10, 2021

Hm , wait @acka47 with your review, it seems like the canonical links are not fixed yet. Investigating...

@dr0i
Copy link
Member

dr0i commented Sep 10, 2021

(Proxy was set to my dr0i test repo. Ok to review now @acka47

@acka47
Copy link
Member Author

acka47 commented Sep 10, 2021

+1 Looks good to me. We will announce the blog as soon as the SSL certificate is installed. (You could also sign it in a video conference and then bring it to hbz next week, @dr0i .)

@acka47 acka47 removed their assignment Sep 10, 2021
@dr0i
Copy link
Member

dr0i commented Sep 23, 2021

Installed SSL certifictates. You may want to ckeck @acka47 .

@acka47
Copy link
Member Author

acka47 commented Sep 23, 2021

+1 Looks good. Unfortunately, hypothes.is annotations are not shown at neither of the blogs now. I opened another issue for this at #7 .

@acka47
Copy link
Member Author

acka47 commented Sep 23, 2021

Closing.

@acka47 acka47 closed this as completed Sep 23, 2021
@sroertgen sroertgen moved this to Done in SkoHub Feb 7, 2023
@sroertgen sroertgen added this to SkoHub Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acka47 acka47

Labels
None yet
Projects
SkoHub
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3 publish blog skohub-io/skohub-blog
3 participants
@acka47 @dr0i @katauber