-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major update Branch LeverageData (mostly regarding quizzes) #31
Comments
Wow thanks for the info and your many changes! I already manually incorporated the bug fixes, i.e.
I also like the new functionality for the quizzes. Your examples look cool. Still I will take some time to implement them and perhaps not implement them all. (I also made some changes to the quizzes to make them usable in RStudio here 0ea201a) I am particularly not sure about the following of your changes:
You could also do this with regular YAML using a | after defining your string, e.g.
For numbering in Rmd, you could just write Also you probably can get rid of the rmdtools dependence, I just put it into RTutor by accident but removed it again in my commit here: 73ba30f Using fewer packages makes everything load quicker. Overall our forks seem to be drifting apart and it may be easier just to incorporate good changes from each other than keeping them identical. You can take a look at my changes here: LeverageData/RTutor@master...skranz:master In partiuclar the improvement in the hints for dplyr chains may be quite useful to incorporate in you fork. |
Thank you for your feedback! Yes both YAML and the markdown autonumbering are certainly design choices. As I expect my quizzes to be written by several persons which have to learn the syntax for the first time (think interns and short-time working students) I would much rather have them spend time on the actual quality and content of the courses themselves. My goal is therefore to have the RTutor Syntax as easy to learn and use as possible. From a general didactic point of view (say for an instructor ;) ) being as close as possible to standard syntax absolutely has its merits, I see that. This is one of the reasons why I didn't opt for a pull request. There are two considerations however I want to highlight if you decide not to incorporate those two particular changes:
|
Note my newest commit. I have changed the structure to the yaml processing, so that the pre and post processing are separated. In this context it is now possible to use negative shorthand commentary (i.e. "Display commentary if a certain answer has not been checken"). I have further disabled yaml functionalities which I didn't know about before and made the expression !any(...) not possible as the ! got interpreted by yaml. |
Sorry, I just realized that my previous "bugfix" to remove the rmdtools dependence, generated another error, because I wrongly set |
I just uploaded a major update to the LeverageData Fork.
The direct effects of the changes can be seen here: https://leveragedata.shinyapps.io/QuizExamples/
In particular I made the following improvements:
All changes are as backwards compatible as possible. All current problem sets should compile as previously and all additional options are stricly optional. The following caveats apply however:
Additionally I changed the commentary in deployapps so that the dataset should be in ./app instead of ./app/work. I am quite confused about this one. ./app./work worked fine until it didn't anymore for newly uploaded problem sets. I am not sure whether this was a change made by myself or by shinyapps. You might want to consider whats happening here seperately from the other changes.
The text was updated successfully, but these errors were encountered: