Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send device id in HW_STATUS package #36

Closed
olell opened this issue Dec 23, 2023 · 0 comments · Fixed by #38
Closed

Send device id in HW_STATUS package #36

olell opened this issue Dec 23, 2023 · 0 comments · Fixed by #38
Assignees
@olell
Labels
bug Something isn't working

Comments

@olell
Copy link
Member

olell commented Dec 23, 2023

Currently there is no way to identify which device has sent the battery status information. I suggest to simply add a field "d_id" which contains the device name ("skrmphsr123456" for example).
@olell olell added the bug Something isn't working label Dec 24, 2023
@olell olell self-assigned this Dec 24, 2023
@olell olell linked a pull request Dec 25, 2023 that will close this issue
Sending device id in HW_STATUS package #38
Merged
@olell olell closed this as completed in #38 Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olell olell

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sending device id in HW_STATUS package skrmsh/skirmish-firmware-esp32
1 participant
@olell