Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Getting a result from the FFT API #115

Open
AKMaily opened this issue Mar 19, 2024 · 4 comments
Open

Enhancement: Getting a result from the FFT API #115

AKMaily opened this issue Mar 19, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@AKMaily
Copy link
Collaborator

AKMaily commented Mar 19, 2024

Location: Generate Training data menu , send button

After the user pressed the send button the waveform he selected is send to the FFT API as a JSON Object. Right now the /check-request endpoint is used.

The enhancement is to change the /check-request endpoint to the /analyze endpoint. The /analyze endpoint gives back a result described in the documentation of the FFT API. This result should be saved in a new .csv file called Analysis_"old measurement_name" in a /analysis folder in the directory where the OmniView.exe is saved. In this .csv file the result is saved as two columns, the first one is the frequency and the second one is the corresponding amplitude.

@AKMaily AKMaily added the enhancement New feature or request label Mar 19, 2024
@R-Abbasi
Copy link
Collaborator

Using current code, https://api.auto-intern.de/analyze's response to sending a .csv file is Internal Server Error. Is the API code under development, please?
Capture1

@R-Abbasi
Copy link
Collaborator

As well as, the Validation Error with the array loc with values of heterogeneous types looks a little unusual to me.

"detail": [
   {
     "loc": [
       "string",
       0
     ],
     "msg": "string",
     "type": "string"
   }
 ]
}

@dobe-1
Copy link
Collaborator

dobe-1 commented Mar 20, 2024

There was an issue with the type declaration of the sampling rate. The sampling rate must be an integer and not a float and must always be specified in hertz. The fixed version will deployed soon as possible.

The Validation Error is a predefined error class of the pydantic library that we use for input validation.

@R-Abbasi
Copy link
Collaborator

#116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants