Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Files and languages Files #21

Open
NP199 opened this issue Sep 21, 2023 · 8 comments
Open

Config Files and languages Files #21

NP199 opened this issue Sep 21, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@NP199
Copy link
Collaborator

NP199 commented Sep 21, 2023

  1. When you start the Omniview Software without the Folder config / languages then it just close, when you have no internet connection.

  2. When the file config / language file is empty there should be a check if the file is valid.

@NP199 NP199 added the bug Something isn't working label Oct 23, 2023
@MaxClerkwell
Copy link
Contributor

When the software is started, it checks if a config.json file exists in the ./config/ directory. If there is no config.json present, a pop-up window appears and asks: "Download config.json from the server? y/n". If a config.json is found, it is loaded and passed through a validation function. If the config is valid, the program checks if a language.json is specified within the config; otherwise, it uses a default language. Additionally, the program checks if a skin.json is set in the config; otherwise, it uses a default skin. The defaults are compiled into the program.

image

@AKMaily
Copy link
Collaborator

AKMaily commented Apr 17, 2024

Is this problem still persisting? Currently, the software is able to initiate without requiring internet connectivity, as the pathway has been corrected. @NP199

@NP199
Copy link
Collaborator Author

NP199 commented Apr 25, 2024

I think the software still needs the config.json and when the costumer does not have the file, the software searches for it online and when it does not find the sofware no json object can be loaded which should lead to fail of the software

@AKMaily
Copy link
Collaborator

AKMaily commented Apr 25, 2024

This happens only if the user deletes the config and also does not have a internet connection. Do you see any solution how this could be fixed ? Because if the user does not have an internet connection and deleted the file, i dont see a way how he could get a config again.

@NP199
Copy link
Collaborator Author

NP199 commented Apr 25, 2024

There could be a default config, which is coded into the binary file and used when no other file is found, something like the language map. Or the programm shuts down like the flow diagram suggests above.

@AKMaily
Copy link
Collaborator

AKMaily commented Apr 25, 2024

I believe embedding the config into the binary file is a good approach. This way, users won't encounter issues or experience software shutdowns even if they accidentally delete the config.

@NP199
Copy link
Collaborator Author

NP199 commented Apr 25, 2024

But with the constraint that if a config is present that the present config will be loaded isntead of the default values. When we fully remove the file then there will be less flexiblilty in an stalbe version to add some dynamic configuration features

@AKMaily
Copy link
Collaborator

AKMaily commented Apr 25, 2024

Yes i agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants