Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Building not possible for outside-collaborators without access to AI private Repos #36

Open
R-Abbasi opened this issue Oct 16, 2023 · 6 comments
Assignees

Comments

@R-Abbasi
Copy link
Collaborator

In case of not having right access to the repo, the following errors turn up:

.../omniview$ git submodule update --init --recursive
Submodule 'ImGuiInstance' (https://github.com/skunkforce/ImGuiInstance.git) registered for path 'ImGuiInstance'
Submodule 'aglio' (https://github.com/dominicpoeschko/aglio.git) registered for path 'aglio
'
Submodule 'ai_omniscope-v2-communication_sw' ([email protected]:AI-Gruppe/ai_omniscope-v2-communication_sw.git) registered for path 'ai_omniscope-v2-communication_sw'
Submodule 'cmake_helpers' (https://github.com/dominicpoeschko/cmake_helpers.git) registered for path 'cmake_helpers'
Submodule 'imgui-filebrowser' (https://github.com/AirGuanZ/imgui-filebrowser.git) registered for path 'imgui-filebrowser'
Cloning into '/home/arydev/Desktop/omniview/ImGuiInstance'...

Cloning into '/home/arydev/Desktop/omniview/aglio'...
Cloning into '/home/arydev/Desktop/omniview/ai_omniscope-v2-communication_sw'...
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.

fatal: clone of '[email protected]:AI-Gruppe/ai_omniscope-v2-communication_sw.git' into submodule path '/home/arydev/Desktop/omniview/ai_omniscope-v2-communication_sw' failed
Failed to clone 'ai_omniscope-v2-communication_sw'. Retry scheduled
Cloning into '/home/arydev/Desktop/omniview/cmake_helpers'...
Cloning into '/home/arydev/Desktop/omniview/imgui-filebrowser'...
Cloning into '/home/arydev/Desktop/omniview/ai_omniscope-v2-communication_sw'...
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of '[email protected]:AI-Gruppe/ai_omniscope-v2-communication_sw.git' into submodule path '/home/arydev/Desktop/omniview/ai_omniscope-v2-communication_sw' failed
Failed to clone 'ai_omniscope-v2-communication_sw' a second time, aborting
.../omniview$

@dominicpoeschko
Copy link
Member

You need access to https://github.com/AI-Gruppe/ai_omniscope-v2-communication_sw
I think @bjoekeldude can give you access

@MaxClerkwell
Copy link
Contributor

Can this be done without inviting him into the organization?
Should this code be public, @dominicpoeschko @NP199, or is there a reason it is in our private repos?

@MaxClerkwell
Copy link
Contributor

I added @R-Abbasi as an outside collaborator to this specific repo. This is just a temporary workaround and we need to find a way to precompile this as a library and make it available.

@NP199
Copy link
Collaborator

NP199 commented Oct 23, 2023

We never specified if we should open source the code for the communication so we didn`t.
We decide to postpone the decission to open source it or not @bjoekeldude.

@MaxClerkwell
Copy link
Contributor

After a discussion last friday, it has been decided, that https://github.com/AI-Gruppe/ai_omniscope-v2-communication_sw will not be public at any point. There will be a serious effort in the last week of november to move the device handling out of this repo and make it available via a .dll or .so.

Anyway, this seems to be a bigger issue, than just a few lines of code. Since that will be needed for OmniView_2 as well, this has to be done at some point.

@odinthenerd, @dominicpoeschko and I will look into this end of november 2023, and decide on a timeline for this migration.

@MaxClerkwell MaxClerkwell changed the title cloning-issue Local Building not possible for outside-collaborators without access to AI private Repos Oct 31, 2023
@MaxClerkwell
Copy link
Contributor

@DonNagual will be working on a prototype implementation, starting at the end of this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants