Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement Request: Integrate VDCS-File Upload below Oscilloscope Scan #45

Open
markuskae opened this issue Oct 24, 2023 · 3 comments
Open

Comments

@markuskae
Copy link
Collaborator

The VDCS-File upload should not be in a separate window. It should be possible below the oscilloscope scan.
Because we have also oscilloscope scans from none VW AG Brands, the VDCS-Scan should not be necessary.

@MaxClerkwell
Copy link
Contributor

MaxClerkwell commented Oct 24, 2023

We should talk about a the correct workflow here first.
"Generate Trainingdata" is a function, that will be used for different Use-Cases. These will have different APIs in the first place. Thus, a Menu-Item called Diagnostics should be introduced in the menu-bar. When dropping down, it shall display a couple of available diagnostics, such as:

  • Compression
  • Timing-Belt
  • Fuel-Delivery-Pump
  • Common-Rail-Pressure
    The latter three shall all be greyed out, but the first one should be available.

It contains a second level drop, revealing the options:

  • Analyze current waveform
  • Generate training data

image

Opening Generate Training Data should open a modal providing an interface to enter:

  • A radio-button
    • User current Waveform (greys out Waveform from file if enabled)
    • Waveform from File (has file-explorer)
  • Auto-Shop UUID (in reference to issue Uploading of Training-Data Request needs to be enhanced #43)
  • VIN
  • Milage
  • Reason for investigation
    • Maintenance
    • Fault
  • Electrical Consumers
    • Off
    • On
  • Assesment
    • Normal
    • Anomaly
  • Comment
  • VCDS Auto-Scan (file-path or drag&drop)

The Issue #25 also references how to extract the VIN from the VCDS Auto-Scan. This shall be done AFTER this was fixed.
Uploading the VCDS File should be handled in a second REST-Request in the code, utilizing the Auto-Scan API. @dobe-1 will provide an API reference within the next couple of days.

@R-Abbasi
Copy link
Collaborator

R-Abbasi commented Nov 1, 2023

Am I now supposed to add a text filed with the label VCDS Auto-Scan under Comment so that the user can put a file path e.g., /home/arydev/Desktop/Projects/Example/file.txt or
drag a file into it, so that the text input shows the path?

@AKMaily
Copy link
Collaborator

AKMaily commented Dec 13, 2023

The user should be able to do both. He should be able to enter the path manually but also drag and drop a file and then see the file name displayed in the VCDS auto-scan field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants