default binging host

stderr for warning

internal/cmd/skupper/site/nonkube/site_create.go

@@ -78,10 +78,6 @@ func (cmd *CmdSiteCreate) ValidateInput(args []string) []error {
 		}
 	}
 
-	if cmd.Flags != nil && cmd.Flags.BindHost == "" && cmd.Flags.EnableLinkAccess {
-		validationErrors = append(validationErrors, fmt.Errorf("bindhost should not be empty"))
-	}
-
 	if cmd.Flags != nil && cmd.Flags.BindHost != "" {
 		ip := net.ParseIP(cmd.Flags.BindHost)
 		ok, _ := hostStringValidator.Evaluate(cmd.Flags.BindHost)

internal/cmd/skupper/site/nonkube/site_create_test.go

@@ -50,10 +50,10 @@ func TestNonKubeCmdSiteCreate_ValidateInput(t *testing.T) {
 			},
 		},
 		{
-			name:           "bindHost was not specified",
+			name:           "bindHost was not specified ok",
 			args:           []string{"my-site"},
 			flags:          &common.CommandSiteCreateFlags{EnableLinkAccess: true},
-			expectedErrors: []string{"bindhost should not be empty"},
+			expectedErrors: []string{},
 		},
 		{
 			name:           "bindHost was not valid",

internal/cmd/skupper/site/nonkube/site_delete_test.go

@@ -11,7 +11,7 @@ import (
 	"github.com/skupperproject/skupper/pkg/apis/skupper/v2alpha1"
 	"github.com/skupperproject/skupper/pkg/nonkube/api"
 	"github.com/spf13/cobra"
-	"gotest.tools/assert"
+	"gotest.tools/v3/assert"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 )

internal/cmd/skupper/site/nonkube/site_status_test.go

@@ -10,7 +10,7 @@ import (
 	"github.com/skupperproject/skupper/internal/nonkube/client/fs"
 	"github.com/skupperproject/skupper/pkg/apis/skupper/v2alpha1"
 	"github.com/skupperproject/skupper/pkg/nonkube/api"
-	"gotest.tools/assert"
+	"gotest.tools/v3/assert"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 )

internal/cmd/skupper/site/nonkube/site_update.go

@@ -173,8 +173,7 @@ func (cmd *CmdSiteUpdate) Run() error {
 			Namespace: cmd.namespace,
 		},
 		Spec: v2alpha1.SiteSpec{
-			Settings:   cmd.options,
-			LinkAccess: "default",
+			Settings: cmd.options,
 		},
 	}
 

internal/cmd/skupper/site/nonkube/site_update_test.go

@@ -11,7 +11,7 @@ import (
 	"github.com/skupperproject/skupper/pkg/apis/skupper/v2alpha1"
 	"github.com/skupperproject/skupper/pkg/nonkube/api"
 	"github.com/spf13/cobra"
-	"gotest.tools/assert"
+	"gotest.tools/v3/assert"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 )
@@ -285,6 +285,7 @@ func TestCmdSiteUpdate_Run(t *testing.T) {
 		errorMessage        string
 		siteName            string
 		flags               common.CommandSiteUpdateFlags
+		linkAccessEnabled   bool
 	}
 
 	testTable := []test{
@@ -297,6 +298,7 @@ func TestCmdSiteUpdate_Run(t *testing.T) {
 				EnableLinkAccess:        true,
 				SubjectAlternativeNames: []string{"2.2.2.2", "test"},
 			},
+			linkAccessEnabled: true,
 		},
 		{
 			name:      "runs ok",
@@ -313,6 +315,7 @@ func TestCmdSiteUpdate_Run(t *testing.T) {
 				SubjectAlternativeNames: []string{"2.2.2.2", "test", "5.6.7.8"},
 				Output:                  "json",
 			},
+			linkAccessEnabled: true,
 		},
 		{
 			name:     "run ok output yaml",
@@ -333,6 +336,7 @@ func TestCmdSiteUpdate_Run(t *testing.T) {
 		command.routerAccessHandler = fs.NewRouterAccessHandler(command.namespace)
 		command.newSettings.bindHost = test.flags.BindHost
 		command.newSettings.subjectAlternativeNames = test.flags.SubjectAlternativeNames
+		command.linkAccessEnabled = test.linkAccessEnabled
 		defer command.siteHandler.Delete("my-site")
 		defer command.routerAccessHandler.Delete("my-site")
 		t.Run(test.name, func(t *testing.T) {

internal/cmd/skupper/site/site.go

@@ -54,7 +54,7 @@ There can be only one site definition per namespace.`,
 	cmd.Flags().StringVarP(&cmdFlags.Output, common.FlagNameOutput, "o", "", common.FlagDescOutput)
 	cmd.Flags().StringVar(&cmdFlags.ServiceAccount, common.FlagNameServiceAccount, "", common.FlagDescServiceAccount)
 	cmd.Flags().DurationVar(&cmdFlags.Timeout, common.FlagNameTimeout, 30*time.Second, common.FlagDescTimeout)
-	cmd.Flags().StringVar(&cmdFlags.BindHost, common.FlagNameBindHost, "", common.FlagDescBindHost)
+	cmd.Flags().StringVar(&cmdFlags.BindHost, common.FlagNameBindHost, "0.0.0.0", common.FlagDescBindHost)
 	cmd.Flags().StringSliceVar(&cmdFlags.SubjectAlternativeNames, common.FlagNameSubjectAlternativeNames, []string{}, common.FlagDescSubjectAlternativeNames)
 	cmd.Flags().StringVar(&cmdFlags.Wait, common.FlagNameWait, "ready", common.FlagDescWait)
 

internal/cmd/skupper/site/site_test.go

@@ -27,7 +27,7 @@ func TestCmdSiteFactory(t *testing.T) {
 				common.FlagNameServiceAccount:          "",
 				common.FlagNameOutput:                  "",
 				common.FlagNameTimeout:                 "30s",
-				common.FlagNameBindHost:                "",
+				common.FlagNameBindHost:                "0.0.0.0",
 				common.FlagNameSubjectAlternativeNames: "[]",
 				common.FlagNameWait:                    "ready",
 			},

internal/nonkube/client/fs/site_handler.go

@@ -2,8 +2,8 @@ package fs
 
 import (
 	"errors"
-	"fmt"
 	"io/fs"
+	"os"
 
 	"github.com/skupperproject/skupper/internal/cmd/skupper/common"
 	"github.com/skupperproject/skupper/pkg/apis/skupper/v2alpha1"
@@ -48,7 +48,7 @@ func (s *SiteHandler) Get(name string, opts GetOptions) (*v2alpha1.Site, error)
 		err, file := s.ReadFile(s.pathProvider.GetRuntimeNamespace(), fileName, common.Sites)
 		if err != nil {
 			if opts.LogWarning {
-				fmt.Println("Site not initialized yet")
+				os.Stderr.WriteString("Site not initialized yet\n")
 			}
 			err, file = s.ReadFile(s.pathProvider.GetNamespace(), fileName, common.Sites)
 			if err != nil {
@@ -93,7 +93,7 @@ func (s *SiteHandler) List() ([]*v2alpha1.Site, error) {
 	path := s.pathProvider.GetRuntimeNamespace()
 	err, files := s.ReadDir(path, common.Sites)
 	if err != nil {
-		fmt.Println("Site not initialized yet")
+		os.Stderr.WriteString("Site not initialized yet\n")
 		path = s.pathProvider.GetNamespace()
 		err, files = s.ReadDir(path, common.Sites)
 		if err != nil {