-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2][non-kube] site create command and CLI adaptation #1563
Conversation
c04b5b6
to
b50248c
Compare
6611375
to
fdbace0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks really good!!
731437c
to
df62748
Compare
A few highlights that may be helpful to review this pull request:
That way the skupper command is decoupled from the logic of managing custom resources in a nonkube way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
built and used against kind cluster various cli operations
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
…ting sites in a nonkube environment
…le for the current environment
@fgiorgetti let me know if something is missing before I merge this pull request. Thanks! |
Thank you very much @nluaces for addressing all the comments. |
--platform
at execution level to avoid dependency on the generic configuration only (through environment variables).PathProvider
. If the user does not provide a namespace (with--namespace
), they will be created in the default namespace.