Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout flag for site commands #1629

Closed
wants to merge 56 commits into from
Closed

Add timeout flag for site commands #1629

wants to merge 56 commits into from

Conversation

nluaces
Copy link
Member

@nluaces nluaces commented Sep 3, 2024

This PR needs to be merged after #1563

@nluaces nluaces added the do-not-merge Work In Progress label Sep 3, 2024
@nluaces nluaces self-assigned this Sep 3, 2024
nluaces added 24 commits September 3, 2024 15:32
@nluaces
add factory method for kube and non-kube site commands
27577a4
@nluaces
refactor site commands to include podman CLI implementation
6de179a
@nluaces
defer stop from the spinner and fix message
815974f
@nluaces
refactor link commands and fix site unit tests
37355ca
@nluaces
adapt token commands for podman implementation
a973105
@nluaces
adapt connector commands to podman CLI
6ccbfef
@nluaces
adapt listener commands to podman CLI
07f063e
@nluaces
removal of AddFlags method in the skupper command interface
cd167fd
@nluaces
refactor common and utils packages
fc187ee
@nluaces
refactor common and utils packages
44dfeca
@nluaces
added path provider
f056aa3
@nluaces
add tests to check not applicable flags in running commands
0cd7136
@nluaces
fix write resources in a specific path for non-kube commands
e46ba8a
@nluaces
fix creating a non-kube site while providing a namespace
32ba805
@nluaces
add custom resources abstraction for nonkube CLI
0bfcafa
@nluaces
move nonkube components to the correct directory
16b1a0a
@nluaces
replace PostRunE by PostRun function in the cobra command definition …
982033a 
…to avoid showing the usage after an error produced by WaitUntil function
@nluaces
fix tests
c42121a
@nluaces
fixed descriptions and spacing based on comments
9424e0d
@nluaces
fix format
db02c3b
@nluaces
fix tests
97f9d13
@nluaces
fix description
78f2277
@nluaces
rename non_kube packages to nonkube
5551539
@nluaces
fix package name
bc38e4b
@nluaces nluaces force-pushed the sk-2084-add-timeout-flag-for-sites branch from ba60402 to d7068de Compare September 3, 2024 14:43
nluaces and others added 24 commits September 12, 2024 16:09
@nluaces
rename attributes to bindHost
4e8742c
@nluaces
add subject alternative names flag for non kube sites
bc4653c
@nluaces
fix descriptions
7f9af84
@nluaces
mark flags as hidden based on the env. variable SKUPPER_PLATFORM
56ab3d4
@nluaces
hide kubernetes flags for non kube configured environments in the hel…
d840814 
…p output
@nluaces
replace validation errors for warnings in cases of flags not applicab…
e6f1f8c 
…le for the current environment
@nluaces
fix path provider paths for nonkube platforms
47ab653
@nluaces
add validation for the user to choose from one of the target types
774a6a4
@lynnemorrison @nluaces
Add unit tests for qdr and ssecuredAccess (skupperproject#1600)
e4d5a2b 
* Add unit tests
pkg/qdr
pkg/securedAccess

* add more secureAccess tests
loadbalancer
router tests
@lynnemorrison @nluaces
Add unit tests for pkg/kube/site directory (skupperproject#1622)
a0ee136 
First tests for site.go
@ajssmith @nluaces
ci updates for v2 (skupperproject#1631)
a127e55
@fgiorgetti @nluaces
Fixed ci job name (skupperproject#1634)
ee29966
@fgiorgetti @nluaces
Fixed ci required job name (skupperproject#1635)
ca82194
@fgiorgetti @nluaces
Fixed v2 images build and push process (skupperproject#1636)
1c6a9fe
@fgiorgetti @nluaces
Typo in bootstrap image (skupperproject#1637)
b082006
@c-kruse @nluaces
fix client cleanup panic (skupperproject#1639)
529a3f9 
Removes superfluous cleanup logic that was the cause of a panic.

Signed-off-by: Christian Kruse <[email protected]>
@c-kruse @nluaces
Include Version in kube/flow's SiteRecord (skupperproject#1613)
18a7326 
* Include Version in kube/flow's SiteRecord

Signed-off-by: Christian Kruse <[email protected]>

* drive by: count skupper-network-console as internal

Signed-off-by: Christian Kruse <[email protected]>

---------

Signed-off-by: Christian Kruse <[email protected]>
@grs @nluaces
Only copy identity related fields for owner references
a3f37cd
@nluaces
adapt token commands for podman implementation
651bfa1
@nluaces
refactor common and utils packages
5eae3fc
@nluaces
added flag to site create command
a1b3e8f
@nluaces
added timeout flag for update and delete site commands
bcdff9d
@nluaces
merge conflicts
96986f0
@nluaces
unify timeout flag
54dc6eb
@nluaces nluaces force-pushed the sk-2084-add-timeout-flag-for-sites branch from f16464e to 54dc6eb Compare September 13, 2024 15:33
@nluaces
Copy link
Member Author

nluaces commented Sep 13, 2024

Closed in favor of #1655

@nluaces nluaces closed this Sep 13, 2024
@nluaces nluaces deleted the sk-2084-add-timeout-flag-for-sites branch October 29, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nluaces nluaces

Labels
do-not-merge Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nluaces @lynnemorrison @ajssmith @fgiorgetti @c-kruse @grs