Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonkube sites enhancement to use namespaces #1641

Merged
merged 23 commits into from
Sep 19, 2024

Conversation

fgiorgetti
Copy link
Member

  • Using namespaces to isolate sites
  • Container names are now prefixed with namespace name
  • Systemd services are now prefixed with namespace name
  • Bootstrap README file updated (cmd/bootstrap/README.md)
  • Bootstrap can now re-initialize a given namespace
  • Bootstrap now accepts bundle strategy flag (or SKUPPER_BUNDLE env variable)
  • Bundle and Tarball strategies are no longer valid SKUPPER_PLATFORM values
  • Bundles can be installed to different and multiple namespaces
  • Bootstrap binary and script now use similar flags
  • Router names now have a dynamic suffix
  • Static status is now added to processed CRs
  • Installation summary is clearer now

@fgiorgetti
Copy link
Member Author

@c-kruse I have addressed the initial feedback.
Let me know if your thoughts.

Copy link
Member

@ajssmith ajssmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built bootstrap locally, ran redis example in myriad ways:

  • w/wo namespace
  • bundle types
  • removal
  • re-init
    LGTM

Copy link
Contributor

@c-kruse c-kruse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @fgiorgetti! Thank you!

@fgiorgetti fgiorgetti merged commit 148dd3d into skupperproject:v2 Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants