Add nonkube site commands and unit tests #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynnemorrison
force-pushed
the
v2_nonkube_site
branch
from
aae3c80 to
0ef2360
Compare
fgiorgetti
reviewed
Nov 18, 2024
lynnemorrison
force-pushed
the
v2_nonkube_site
branch
from
5cec5f7 to
78a4e47
Compare
fgiorgetti
reviewed
Dec 3, 2024
lynnemorrison
force-pushed
the
v2_nonkube_site
branch
from
78a4e47 to
f5d00f8
Compare
lynnemorrison
force-pushed
the
v2_nonkube_site
branch
from
f5d00f8 to
e7e0c1e
Compare
nluaces
reviewed
Dec 12, 2024
| var validationErrors []error | ||
|
|
||
| if cmd.Flags.ServiceAccount != "" { |
There was a problem hiding this comment.
looks like a mistake. I'll add it back
lynnemorrison
force-pushed
the
v2_nonkube_site
branch
from
e7e0c1e to
f496955
Compare
nluaces
approved these changes
Dec 12, 2024
nluaces
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add update, delete and status site CLI commands
Currently create router-access if user configures enable-link-access.
Add unit tests.