Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename 'video' to 'video wrapper' #219

Open
ninadel opened this issue May 8, 2014 · 2 comments
Open

rename 'video' to 'video wrapper' #219

ninadel opened this issue May 8, 2014 · 2 comments

Comments

@ninadel
Copy link

ninadel commented May 8, 2014

we eventually want to add design specs for the video player to the toolkit
to prevent future confusion, i would suggest renaming 'video' to 'video wrapper'

@peter-mouland peter-mouland added this to the 2.3-Idray-the-Winter-King milestone May 16, 2014
@peter-mouland
Copy link
Contributor

moved this to milestone 2.3 as a thanks for designs input :)

@peter-mouland
Copy link
Contributor

we would have to work out if the css/js should also change to match and whether or not we keep alias' to the old function so as not to be a breaking change. If we keep the alias, it would be worth starting a 3.0 milestone listing the alias' to remove.

@peter-mouland peter-mouland removed this from the 2.3-Idray-the-Winter-King milestone Aug 27, 2014
@peter-mouland peter-mouland added this to the componentization milestone Aug 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants