Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IE9] Page content is still scrollable when lightbox is triggered, leading to a repaint issue #298

Open
jameshopkins opened this issue Oct 31, 2014 · 4 comments

Comments

@jameshopkins
Copy link
Contributor

In IE9, when both the computed height of the '.lightbox' and HTML element is sufficient to allow clipping of their containing block (the viewport), the latter element is still scrollable, even though overflow: hidden is applied to the BODY element. This, in turn, leads to repaint issues of the page content upon scrolling.

The fix seems to be adding overflow: hidden to the HTML element.

@jameshopkins
Copy link
Contributor Author

I've spent some time today looking into this a bit more.

By opening Developer Tools, going to 'HTML', and clicking the 'HTML' node (or any of it's descendants), the issue remedies itself.

I've also disabled both scroll event listeners on window to rule out any race conditions/conflicts.

So, still no fix; although I'd be happy to pair with someone on this further sometime.

@peter-mouland
Copy link
Contributor

hey, what team are you in (just so i can put you in the right team on here)?

cool, pairing sounds good then. we can create a new project and separate the code into a component (which we're doing to all toolkit code).

half a day to get going should be plenty of time.

@peter-mouland
Copy link
Contributor

@jameshopkins let me know if you wanted to work together on create the lightbox as a component to get this fixed

@jameshopkins
Copy link
Contributor Author

Hey @peter-mouland. Apologies I haven't been contactable for a while. I'll speak to my scrum master to see if there's time for me to pair up with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants