Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle-wrapper.jar does not exist in the build output monument-all.jar #1

Open
Fallen-Breath opened this issue Nov 14, 2024 · 1 comment

Comments

@Fallen-Breath
Copy link

Fallen-Breath commented Nov 14, 2024

To reproduce

  1. Run gradle build
  2. Inspect the output artifact build/libs/monument-all.jar, check what the path gradle_env/gradle/wrapper/ contains

Expected behavior

There's a gradle_env/gradle/wrapper/gradle-wrapper.jar file

Actual behavior

The gradle_env/gradle/wrapper/gradle-wrapper.jar file does not exist in the monument-all.jar

Why

See the gradle shadow plugin doc https://github.com/GradleUp/shadow/blob/e538080d3a55016eaa0254053590ecbec17f6397/src/docs/configuration/dependencies/README.md?plain=1#L23-L29

@Fallen-Breath
Copy link
Author

A fix that seems to be working for this, just for a reference: Fallen-Breath@3a1d19c

If the above fix looks good to you, I can also submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant